Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix printing tf template with multiple ip addresses #447

Merged
merged 1 commit into from
Feb 25, 2022
Merged

fix printing tf template with multiple ip addresses #447

merged 1 commit into from
Feb 25, 2022

Conversation

kon-angelo
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind bug
/platform azure

What this PR does / why we need it:

Fixes an error when printing the terraform template when a user provides >1 public IPs for the NAT Gateway
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixes a bug in the terraform manifest generation when more than one public IP Addresses were provided for the NAT Gateway

@kon-angelo kon-angelo added this to the v1.26 milestone Feb 25, 2022
@kon-angelo kon-angelo requested review from a team as code owners February 25, 2022 08:47
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 25, 2022
dkistner
dkistner approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc @mandelsoft, @dguendisch

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 25, 2022
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 25, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 25, 2022
@dkistner dkistner merged commit 8404f7b into gardener:master Feb 25, 2022
@kon-angelo kon-angelo deleted the fix-tf-tpl-ip branch December 12, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kon-angelo @dkistner @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot